Merge pull request #2836 from PrismLibrary/transient-factory

PrismLibrary · Mar 5, 2023 · 8fcc856 · 8fcc856
2 parents 403b313 + d3ee5bf
commit 8fcc856
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/Containers/Prism.DryIoc.Shared/DryIocContainerExtension.cs b/src/Containers/Prism.DryIoc.Shared/DryIocContainerExtension.cs
@@ -235,7 +235,7 @@ public IContainerRegistry Register(Type from, Type to, string name)
         /// <returns>The <see cref="IContainerRegistry" /> instance</returns>
         public IContainerRegistry Register(Type type, Func<object> factoryMethod)
         {
-            Instance.RegisterDelegate(type, r => factoryMethod());
+            Instance.RegisterDelegate(type, r => factoryMethod(), Reuse.Transient);
             return this;
         }
 
@@ -247,7 +247,7 @@ public IContainerRegistry Register(Type type, Func<object> factoryMethod)
         /// <returns>The <see cref="IContainerRegistry" /> instance</returns>
         public IContainerRegistry Register(Type type, Func<IContainerProvider, object> factoryMethod)
         {
-            Instance.RegisterDelegate(type, factoryMethod);
+            Instance.RegisterDelegate(type, factoryMethod, Reuse.Transient);
             return this;
         }
 

diff --git a/tests/Containers/Prism.Container.Shared/Tests/ContainerFixture.cs b/tests/Containers/Prism.Container.Shared/Tests/ContainerFixture.cs
@@ -438,6 +438,24 @@ public void LocatesImplementationType()
             Assert.Equal(typeof(ServiceA), type);
         }
 
+        [Fact]
+        public void RegisterTransientDelegateReturnsNewInstanceEachTime()
+        {
+            var container = Setup.CreateContainer();
+            Setup.Registry.Register<ServiceA>(() => new ServiceA());
+
+            Assert.NotSame(container.Resolve<ServiceA>(), container.Resolve<ServiceA>());
+        }
+
+        [Fact]
+        public void RegisterTransientDelegateWithContainerReturnsNewInstanceEachTime()
+        {
+            var container = Setup.CreateContainer();
+            Setup.Registry.Register<ServiceA>(x => new ServiceA());
+
+            Assert.NotSame(container.Resolve<ServiceA>(), container.Resolve<ServiceA>());
+        }
+
         private static IServiceA CreateService() =>
             new ServiceA { SomeProperty = "Created through a factory" };