Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerfile: Trim merge base #2761

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Feb 12, 2021

I made a mistake in #2757. The merge base commit returned by git is followed by an extra newline character. I didn't catch this while testing and it caused the CI in #2760 to fail.

The solution is to simply trim the extra newline character. I also trimmed the output of another git command for safety.


I will immediately merge this.

@github-actions
Copy link

Fails
🚫

node failed.

Log

danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against cae7de2

@RunDevelopment RunDevelopment merged commit 45b0e82 into PrismJS:master Feb 12, 2021
@RunDevelopment RunDevelopment deleted the danger-fix branch February 12, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant