Skip to content
This repository has been archived by the owner on Aug 12, 2021. It is now read-only.

Template: book detail page #91

Open
2 tasks done
thatbudakguy opened this issue Jul 6, 2018 · 2 comments
Open
2 tasks done

Template: book detail page #91

thatbudakguy opened this issue Jul 6, 2018 · 2 comments

Comments

@thatbudakguy
Copy link
Contributor

thatbudakguy commented Jul 6, 2018

zeplin links

L / M / S

notes

  • "back" link should go back to active search
  • table should be responsive
@dschlein
Copy link

Testing on a macbook pro laptop 13 inches: The labels are very close to their information sets, so they look squished.
Testing on Ipad: same squished wrapping issue - sizing issue.
For both macbook and ipad, the labels are all at their top of their cells, except for Notes, which is centered.
On an android phone, Nexus 5x: the tabular data flows well. No wrapping issues.

@thatbudakguy
Copy link
Contributor Author

Couldn't replicate any of these spacing issues using the safari iOS emulator for iPad, or using the 1366x768 OSX mode for a 13" laptop. Everything looks normal to me.

@dschlein if you get a chance could you maybe post a screenshot? There's instructions for how to post them in a comment here (basically you just drag and drop the file into the comment box).

on a mac, you can take a screenshot with ⌘ command shift 4 and then drag the box around what you want to screenshot. it will create an image file on your desktop.

@thatbudakguy thatbudakguy removed their assignment Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants