remove publisher, translator, and filters

Princeton-CDH · Aug 9, 2018 · 6219d8a · 6219d8a
1 parent 9e06c33
commit 6219d8a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 79 deletions.
diff --git a/sitemedia/js/components/FilterChoice.js b/sitemedia/js/components/FilterChoice.js
diff --git a/sitemedia/js/components/SearchFilter.js b/sitemedia/js/components/SearchFilter.js
diff --git a/sitemedia/js/components/books/BooksSearch.js b/sitemedia/js/components/books/BooksSearch.js
@@ -2,7 +2,6 @@ import { mapGetters, mapActions, mapState, mapMutations } from 'vuex'
 import { isEmpty } from 'lodash'
 
 import SearchFacet from '../SearchFacet'
-import SearchFilter from '../SearchFilter'
 import SearchSort from '../SearchSort'
 
 export default Vue.component('BooksSearch', {
@@ -57,14 +56,13 @@ export default Vue.component('BooksSearch', {
     </div>`,
     components: {
         SearchFacet,
-        SearchFilter,
         SearchSort,
     },
     data() {
         return {
             tabs: [ // array of arrays specifying how facets should be grouped into tabs
-                ['author', 'editor', 'translator'],
-                ['publisher', 'pub_year'],
+                ['author', 'editor'],
+                ['pub_year'],
                 ['language', 'subject'],
                 ['annotator']
             ],
@@ -82,18 +80,6 @@ export default Vue.component('BooksSearch', {
                     label: 'Editor',
                     type: 'text',
                 },
-                {
-                    name: 'translator',
-                    label: 'Translator',
-                    type: 'text',
-                },
-                {
-                    name: 'publisher',
-                    label: 'Publisher',
-                    type: 'text',
-                    search: true,
-                    width: 6
-                },
                 {
                     name: 'pub_year',
                     label: 'Publication Year',
@@ -119,7 +105,6 @@ export default Vue.component('BooksSearch', {
     },
     computed: {
         ...mapState([
-            'filters',
             'totalResults',
             'facetChoices',
         ]),

diff --git a/winthrop/books/forms.py b/winthrop/books/forms.py
@@ -142,7 +142,7 @@ class SearchForm(forms.Form):
     # Solr facet choice fields
     author = FacetChoiceField()
     editor = FacetChoiceField()
-    translator = FacetChoiceField()
+    # translator = FacetChoiceField() NOTE temp disabled as not lv1 feature
     language = FacetChoiceField()
     subject = FacetChoiceField()
     annotator = FacetChoiceField()

diff --git a/winthrop/books/tests/test_book_views.py b/winthrop/books/tests/test_book_views.py
@@ -215,11 +215,11 @@ def test_book_list(self):
         assert response.context['object_list'][0]['title'] == \
             books.get(creator__person__authorized_name='Heinsius, Daniel').title
 
-        # by translator
-        response = self.client.get(url, {'translator': ['Tellus, Sylvester']})
-        assert len(response.context['object_list']) == 1
-        assert response.context['object_list'][0]['title'] == \
-            books.get(creator__person__authorized_name='Tellus, Sylvester').title
+        # by translator NOTE disabled as not lv1 feature
+        # response = self.client.get(url, {'translator': ['Tellus, Sylvester']})
+        # assert len(response.context['object_list']) == 1
+        # assert response.context['object_list'][0]['title'] == \
+        #     books.get(creator__person__authorized_name='Tellus, Sylvester').title
 
         # by annotator
         # create annotation on first book with a canvas