Improve project #79
Merged
Improve project #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Progi1984
commented
Apr 2, 2021
•
Progi1984
commented
| Questions | Answers |
|---|---|
| Description? | Improve project (Renamed Readme.md / Added dependabot / Added template for PR / Added PHP Workflow & Build Release) & Removed Travis CI |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| How to test? | Github Actions are 🟢 https://github.com/Progi1984/gamification/actions |
Progi1984
force-pushed
the
improveProject
branch
14 times, most recently
from
7fd8377
to
4f56ea2
Compare
Progi1984
force-pushed
the
improveProject
branch
from
4f56ea2
to
a1b90a5
Compare
35 tasks
PierreRambaud
approved these changes
Apr 2, 2021
|
Thank you @Progi1984 |
Comment on lines
+312
to
+321
| $public_key = file_get_contents(__DIR__ . '/prestashop.pub'); | ||
| $signature = isset($data->signature) ? base64_decode($data->signature) : ''; | ||
|
|
||
| if (isset($data->conditions)) { | ||
| if ( | ||
| function_exists('openssl_verify') | ||
| && self::TEST_MODE === false | ||
| && isset($data->advices_lang) | ||
| && !openssl_verify(json_encode([$data->conditions, $data->advices_lang]), $signature, $public_key) | ||
| ) { |
There was a problem hiding this comment.
These changes haven't been accounted for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.