Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort alphabetically #33

Merged
merged 2 commits into from Aug 16, 2022
Merged

Sort alphabetically #33

merged 2 commits into from Aug 16, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2022

I hope I didn't forget a repo

Questions Answers
Description? Sort alphabetically
Type?
BC breaks?
Deprecations?
Fixed ticket?
How to test?
Possible impacts?

I hope I didn't forget a repo
@atomiix
Copy link
Contributor

atomiix commented Aug 2, 2022

I'm not sure we should add native-modules to the list as commits are made automatically by a bot 🤔

@ghost
Copy link
Author

ghost commented Aug 2, 2022

@atomiix i see missing modules for example blockreassurance, but i aggree you we need to exclude the bot

@atomiix
Copy link
Contributor

atomiix commented Aug 2, 2022

You're right about blockreassurance! I'm adding it right now!

@ghost
Copy link
Author

ghost commented Aug 2, 2022

I remove the line 'PrestaShop/native-modules', but i think we can keep the new sort ?

@ghost ghost changed the title Add native-module and change order Sort alphabetically Aug 2, 2022
@matks
Copy link
Contributor

matks commented Aug 16, 2022

Thank you @okom3pom

@matks matks merged commit 93b1900 into PrestaShop:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants