Devtools #88
Devtools #88
Conversation
Matt75
commented
May 28, 2020
•
Matt75
commented
- Add php-dev-tools
- Add Github Actions
- Run header-stamp
- Run php-cs-fixer
- Run phpstan
- Fix phpstan feedbacks
Matt75
force-pushed
the
devtools
branch
5 times, most recently
from
60f6973
to
c7bf9d8
Compare
| @@ -0,0 +1,61 @@ | |||
| name: Build & Release draft | |||
There was a problem hiding this comment.
Having release drafter AND this GA will be OK ? They will not fight each other ?
There was a problem hiding this comment.
This is actually how we should trigger release drafter from now. They replaces their application with a GitHub Action
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| presta-versions: ['1.7.0.3', 'latest'] |
There was a problem hiding this comment.
So this GA will go through all PS versions from 1.7.0.3 to latest ?
It's not too long ?
There was a problem hiding this comment.
No, it's only running on provided docker tag : so only for tag 1.7.0.3 and tag latest 😉
4 completed jobs in 1m 57s
There was a problem hiding this comment.
Ah ok 😄
So maybe it would be interesting to run it against the 3 latest versions as these are the "most used" versions ?
=> presta-versions: ['1.7.0.3', '1.7.5.2', '1.7.6.5', 'latest']
There was a problem hiding this comment.
We running PHPStan only if we know breaking changes that can potentially broken module.
There were several between 1.7.0.3 and latest but no need to test others versions for this module.
