Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id of the div to avoid duplications #175

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

kpodemski
Copy link
Contributor

Questions Answers
Description? Having duplicated ids is invalid HTML
Type? bug fix
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#23312.
How to test? You need to have two consents on the same page, make sure that there are no duplicated IDs anymore. Details in the Issue.

Important I will update ps_emailalerts module because it is a breaking change for third-party modules.

Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and you are right, this id can be a dependency on anything, let's tag it as a BC

Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kpodemski ,

Thanks for the PR.

Tested with psgdpr v1.4.2 on develop and 1.7.8.x branch.

There's no more duplication of ID. Now I only have a class element :
Screenshot 2022-04-28 at 15 28 06

Screenshot 2022-04-28 at 15 28 30

It is QA ✅
Thanks!

@kpodemski
Copy link
Contributor Author

Thanks @florine2623 :)

@kpodemski kpodemski modified the milestones: 1.4.3, 1.5.0 Apr 28, 2022
@kpodemski kpodemski merged commit 7f095bb into PrestaShop:dev Apr 28, 2022
@Progi1984 Progi1984 modified the milestones: 1.5.0, 1.4.3 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BOOM-5823] psgdpr - the content has wrong id
4 participants