Remove the deprecated method Tools::jsonDecode, Fix Reset & Bump to 1.4.1
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeKeyCool
approved these changes
Mar 25, 2022
PierreRambaud
approved these changes
Mar 25, 2022
matks
approved these changes
Mar 26, 2022
florine2623
previously requested changes
Mar 29, 2022
There was a problem hiding this comment.
Hello @Progi1984 ,
Thanks for the PR !
Tested upgrade to 1.4.1, install, configuration, reset, disable/enable, uninstall.
On PS develop branch (on branch 1.7.8.x it is OK), I get an error when I try to Get my data to PDF or CSV from my customer account 🚫 :
Screen.Recording.2022-03-29.at.11.05.35.mov
Could you check ?
Thanks!
matks
approved these changes
Apr 4, 2022
PierreRambaud
approved these changes
Apr 5, 2022
MeKeyCool
approved these changes
Apr 5, 2022
Progi1984
force-pushed
the
removeToolsJsonDecode
branch
from
0aa9194
to
ce465df
Compare
Progi1984
force-pushed
the
removeToolsJsonDecode
branch
from
ce465df
to
8813cc7
Compare
MeKeyCool
approved these changes
Apr 6, 2022
florine2623
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Hello @Progi1984 ,
Tested on 1.7.8.x and develop.
In BO, tested upgrade, reset, disable/enable on desktop and mobile, configuration of module.
Checked in FO in customer account "get your data" buttons and consent checkboxes.
LGTM, it is QA ✅
|
Thank you @Progi1984 @florine2623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools::jsonDecode* Reset the module (no problem anymore)
* Go to configure page (no problem anymore)
* Release Test