Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed hooks registerGDPRConsent & actionDeleteGDPRCustomer as hook listeners are not defined #161

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Removed hooks registerGDPRConsent & actionDeleteGDPRCustomer as hook listeners are not defined #161

merged 2 commits into from
Feb 18, 2022

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Feb 15, 2022 •
edited
Loading

Questions Answers
Description? Removed hooks registerGDPRConsent & actionDeleteGDPRCustomer as hook listeners are not defined
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Relative to PrestaShop/PrestaShop#19230
How to test? Install this branch
psgdpr is not linked to the hook registerGDPRConsent & actionDeleteGDPRCustomer
In upgrade, hooks registerGDPRConsent & actionDeleteGDPRCustomer are unlinked.

@Progi1984 Progi1984 added this to the 1.3.1 milestone Feb 15, 2022
@Progi1984 Progi1984 added the bug Something isn't working label Feb 15, 2022
@Progi1984 Progi1984 requested a review from a team February 15, 2022 13:38
@Progi1984 Progi1984 mentioned this pull request Feb 15, 2022
Merged
@Progi1984 Progi1984 changed the title Removed the hook registerGDPRConsent as the hook listener is not defined Removed hooks registerGDPRConsent & actionDeleteGDPRCustomer as hook listeners are not defined Feb 15, 2022
@florine2623 florine2623 self-assigned this Feb 17, 2022
florine2623
florine2623 reviewed Feb 18, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

Thanks for the PR !

In psgdpr, v1.4.0, the hooks registerGDPRConsent and actionDeleteGDPRCustomer are removed ✅
Tested usual cases, it works well.

Before approving this, what about this part of the issue PrestaShop/PrestaShop#19230 (comment) ?

In debug mode, throw an exception like this when that happens:
Hook with the name %hookName% has been registered by %moduleClassName%, but the corresponding method %functionName% has not been defined in the Module class.

Should it be done in this PR ? another one ? wdyt ?

Thanks !

@Progi1984
Copy link
Member Author

@florine2623 This PR fixes the issue for the module psgdpr.

florine2623
florine2623 approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok noted !
Then it looks good to me.

Tested :

  • hook/unhook psgdpr
  • configured checkboxes, check on FO if well displayed
  • export info
  • deleted customer
  • downloaded invoices
  • tested features in customer account

QA ✅
Thanks!

@Progi1984 Progi1984 merged commit 6469643 into PrestaShop:dev Feb 18, 2022
@Progi1984 Progi1984 deleted the issue19230 branch February 18, 2022 20:09
@Progi1984
Copy link
Member Author

Thanks @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@kpodemski kpodemski kpodemski approved these changes

@florine2623 florine2623 florine2623 approved these changes

Assignees

@florine2623 florine2623

Labels
bug Something isn't working QA ✔️
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Progi1984 @matthieu-rolland @kpodemski @florine2623