Avoid warning open_basedir restriction (using fetch instead of display) #154
Conversation
PrestaEdit
commented
Dec 7, 2021
•
PrestaEdit
commented
| Questions | Answers |
|---|---|
| Description? | Avoided the "Warning: file_exists(): open_basedir restriction in effect. File(/views/templates/front/customerAccount.tpl) is not within the allowed path(s)" due a slash before the "views" on the file route. Also update the line with the "$this->fetch" function (like #152 , thx to @danidomen) + use of fetch instead of display) |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? | Enable debug mode, check that warning not rise |
|
Regarding the other PR discussion, no needs :D |
|
It's the same issue, I can even close this one and make a suggestion to the another, I don't think about it. My bad. |
|
Oh sorry I didn't see that it was for the same file. I prefer fetch to display. The PR is in QA let's wait for it to be merged and then yours so that everyone's work is rewarded. |
There was a problem hiding this comment.
Hi everyone, unfortunately php-cs-fixer rejects this contribution.
Also can someone to write clearly what is supposed to be broken in develop, why this PR fixes it, and the difference between display() and fetch() and why fetch() is better 😉
Don't assume the person in front knows all 😄 these informations will be very useful
- for reviewers
- for testers
- for developers who discover this change in the future and wonder why such changes were needed
There was a problem hiding this comment.
HI @PierreRambaud,
Can we have an issue and the steps to reproduce to let the team QA test it correctly ?
Thank you :)
It can be tested by a dev as the only thing you have to do is to configure the open_basedir php configuration |
|
@AureRita Is this OK for you if we consider this PR should be tested by developers? |
|
Hi @matks , Yes, I think this PR could be tested by developers |
|
Everything worked as expected, it's QA ✔ |
