Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some translations for the German language #111

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

levyn
Copy link
Contributor

@levyn levyn commented Nov 15, 2020

Some lines of translation have an incorrect template name.

Questions Answers
Description? Some lines of translation have an incorrect template name. Any of Prestashop 1.7 versions.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? You should install the module in the shop on german language, and you can see the gdpr block in the customer account is not translating

@PierreRambaud
Copy link
Contributor

ping @Julievrz wdyt?

@Progi1984
Copy link
Member

@Julievrz Ping for the wording.

@Julievrz
Copy link
Contributor

@Julievrz Ping for the wording.

No wording in this PR haha :)

@Progi1984
Copy link
Member

@levyn Thank you for your contribution. Could you rebase your PR ?

Copy link

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution @levyn 👍

We have this policy that merge commits are not allowed in pull requests 😅

@levyn levyn force-pushed the patch-1 branch 2 times, most recently from 7deafc3 to 6ddcf3b Compare October 28, 2021 17:27
@levyn levyn changed the base branch from master to dev October 28, 2021 17:30
@levyn
Copy link
Contributor Author

levyn commented Oct 28, 2021

@matthieu-rolland
Done

@Progi1984
Copy link
Member

@levyn Could you remove merge commits ?

@Progi1984 Progi1984 modified the milestones: 1.3.0, 1.3.1 Nov 4, 2021
@Progi1984 Progi1984 merged commit 2f131a8 into PrestaShop:dev Nov 4, 2021
@Progi1984
Copy link
Member

Thanks @levyn & @sarahdib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants