Remove hexadecimal value in module field that is never used anyway #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Jan 10, 2025
•
jolelievre
commented
| Questions | Answers |
|---|---|
| Description? | Remove hexadecimal value in module field that is never used anyway |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes validation of module |
| How to test? | The module must behave as it used to |
nicosomb
approved these changes
Jan 10, 2025
boherm
approved these changes
Jan 10, 2025
|
Hello @jolelievre, I tested the module with your PR and it's good for me! 🎉 Thanks! |
paulnoelcholot
approved these changes
Jan 13, 2025
paulnoelcholot
added
QA ✔️
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.