Fix slide url + refacto #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharakPL
commented
Mar 10, 2023
ghost
previously approved these changes
Mar 12, 2023
leemyongpakvn
previously approved these changes
Mar 13, 2023
|
Changed the function name, but it's used only in this file so it shouldn't be considered a BC break. |
Hlavtox
approved these changes
Mar 13, 2023
MhiriFaten
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Hello @SharakPL ,
I have checked your PR :
PS8.0.1 ✔️
The issue is well fixed.
PS1.7.8.8 ❌
Untitled_.Mar.14.2023.11_35.AM.webm
The image slide still with the old URL after editing and saving (Same problem with Title, Caption and description)
Could you checked it please?
Thank you.
|
@MhiriFaten you saved url for english version
but checked the result on french
Please check again for correct version. |
MhiriFaten
approved these changes
Mar 14, 2023
|
Thanks @MhiriFaten :) |
|
thanks @SharakPL 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/2. Change the slide's link
3. Check the link set on this slide in FO.
Links to test:
http://prestashop.com/en/downloadhttps://prestashop.com/en/download//prestashop.com/en/downloadprestashop.com/en/download/content/4-about-uscontent/4-about-usindex.phpsearch?controller=search&s=mug#footerExpected result for shop domain
localhost:8001:http://prestashop.com/en/downloadhttps://prestashop.com/en/download//prestashop.com/en/download//prestashop.com/en/downloadhttp://localhost:8001/content/4-about-ushttp://localhost:8001/content/4-about-ushttp://localhost:8001/index.phphttp://localhost:8001/search?controller=search&s=mug#footer