Replace oudated jqueryuiSortable by modern SortableJS #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while it is not common in Core yet
while it is not common in Core yet
SharakPL
approved these changes
Jan 7, 2023
|
Well done @leemyongpakvn 👏 thank you |
|
Great @kpodemski 🎆 . I think we need to complete the related ongoing PR with blockreassurance before closing PrestaShop/PrestaShop#30210. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I already made a similar PR for blockreassurance module. NeOMakinG suggested adding SortableJS to the Core js there to use as a common library, but waiting to the next major version is indefinite so I chose using SortableJS as the module's local lib here)
2. Clear Web browser cache and PrestaShop BO cache
3. Check sortable feature in the module BO Config's Slides list to make sure the item can be dragged, dropped and saved there, then showed in FO accordingly, as usual.