Release 3.1.1 #72
Merged
Release 3.1.1 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Progi1984
commented
Apr 11, 2022
Progi1984
commented
| Questions | Answers |
|---|---|
| Description? | Release 3.1.1 |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| How to test? | Release Test |
Add dependabot config file
Buttons should be updated
Update short descrption and logo
Migrated Travis CI to Github Actions
Bumps [prestashop/php-dev-tools](https://github.com/PrestaShop/php-dev-tools) from 3.15.1 to 3.16.0. - [Release notes](https://github.com/PrestaShop/php-dev-tools/releases) - [Commits](PrestaShop/php-dev-tools@v3.15.1...v3.16.0) --- updated-dependencies: - dependency-name: prestashop/php-dev-tools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…shop/php-dev-tools-3.16.0 Bump prestashop/php-dev-tools from 3.15.1 to 3.16.0
Bumps [prestashop/php-dev-tools](https://github.com/PrestaShop/php-dev-tools) from 3.16.0 to 3.16.1. - [Release notes](https://github.com/PrestaShop/php-dev-tools/releases) - [Commits](PrestaShop/php-dev-tools@v3.16.0...v3.16.1) --- updated-dependencies: - dependency-name: prestashop/php-dev-tools dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…shop/php-dev-tools-3.16.1 Bump prestashop/php-dev-tools from 3.16.0 to 3.16.1
Fix an issue with protected variable
Do not add scheme for empty or anchor links
Fix language selector
Improved Github Action (Support PHP 5.6 => 8.1)
Bump version to 3.1.1
NeOMakinG
previously approved these changes
Apr 12, 2022
florine2623
reviewed
Apr 13, 2022
There was a problem hiding this comment.
Hello @Progi1984 ,
Tested on 1.7.8.x and develop branch.
- CRUD ok
- anchor links work well
- checked BO and FO display
- configure settings and slides list
There's 2 remaining issues :
I have a warning when I try to add a new slider 🚫
The length of the field in the configuration form is not ok, it should be the same length as all other fields.
on develop branch 🚫
on 1.7.8.X branch ✅
responsive is OK
Could you check ?
Thanks!
|
@florine2623 The PR for fixing these bugs : #73. |
Fix configuration form (Responsive & Default values)
|
@florine2623 Congratulations 🎉 You unlock the release :) |
NeOMakinG
approved these changes
Apr 27, 2022
florine2623
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Hello @Progi1984 ,
The previous bug has been fixed ! It is looking good to me on develop and 1.7.8.x.
QA ✅
|
Thanks @florine2623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.