BO: Fixed position with new slide and remove check on non present input position #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right, this method need to stay public. And about new slide added, get the next position with my commit ? |
Progi1984
approved these changes
Apr 2, 2020
matthieu-rolland
approved these changes
May 27, 2020
|
Ping @Quetzacoalt91 to @beyondsagency question ;) |
Quetzacoalt91
approved these changes
May 27, 2020
|
Ping @beyondsagency for answer ;) |
|
OK can we merge ? |
|
@beyondsagency Sorry, I forgot to send QA ;) |
|
Thanks @beyondsagency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for ps_imageslider whe we add a new slide the position is not good and we have function getNextPosition() not use, so use it :)
Beyonds, Digital Agency