Fixed PHPStan

PrestaShop · Apr 2, 2021 · 17cd250 · 17cd250
1 parent b71119b
commit 17cd250
Show file tree

Hide file tree

Showing 9 changed files with 30 additions and 8 deletions.
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -49,7 +49,7 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                presta-versions: ['1.7.1.2', '1.7.2.5', '1.7.3.4', '1.7.4.4', '1.7.5.2', '1.7.6.9', '1.7.7.3', 'latest']
+                presta-versions: ['1.7.1.2', '1.7.2.5', '1.7.3.4', '1.7.4.4', '1.7.5.1', '1.7.6.9', '1.7.7.3', 'latest']
         steps:
             - name: Setup PHP
               uses: shivammathur/setup-php@v2

diff --git a/ps_featuredproducts.php b/ps_featuredproducts.php
@@ -135,7 +135,7 @@ public function getContent()
             if (!Validate::isBool($rand)) {
                 $errors[] = $this->trans('Invalid value for the "randomize" flag.', [], 'Modules.Featuredproducts.Admin');
             }
-            if (isset($errors) && count($errors)) {
+            if (count($errors)) {
                 $output = $this->displayError(implode('<br />', $errors));
             } else {
                 Configuration::updateValue('HOME_FEATURED_NBR', (int) $nbr);

diff --git a/tests/phpstan.sh b/tests/phpstan.sh
diff --git a/tests/phpstan/phpstan-1.7.1.2.neon b/tests/phpstan/phpstan-1.7.1.2.neon
@@ -1,2 +1,7 @@
 includes:
-	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+
+parameters:
+  ignoreErrors:
+    - '#Call to method assign\(\) on an unknown class Smarty_Data#'
+    - '#Parameter \#1 \$idCategory of class Category constructor expects null, int given#'
diff --git a/tests/phpstan/phpstan-1.7.2.5.neon b/tests/phpstan/phpstan-1.7.2.5.neon
@@ -1,2 +1,7 @@
 includes:
-	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+
+parameters:
+  ignoreErrors:
+    - '#Call to method assign\(\) on an unknown class Smarty_Data#'
+    - '#Parameter \#1 \$idCategory of class Category constructor expects null, int given#'
diff --git a/tests/phpstan/phpstan-1.7.4.4.neon b/tests/phpstan/phpstan-1.7.4.4.neon
@@ -1,2 +1,6 @@
 includes:
-	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+
+parameters:
+  ignoreErrors:
+    - '#Parameter \#1 \$idCategory of class Category constructor expects null, int given#'
diff --git a/tests/phpstan/phpstan-1.7.5.1.neon b/tests/phpstan/phpstan-1.7.5.1.neon
@@ -0,0 +1,6 @@
+includes:
+	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+
+parameters:
+  ignoreErrors:
+    - '#Parameter \#1 \$idCategory of class Category constructor expects null, int given#'
diff --git a/tests/phpstan/phpstan-1.7.5.2.neon b/tests/phpstan/phpstan-1.7.5.2.neon
diff --git a/tests/phpstan/phpstan-1.7.6.9.neon b/tests/phpstan/phpstan-1.7.6.9.neon
@@ -1,2 +1,6 @@
 includes:
-	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
+
+parameters:
+  ignoreErrors:
+    - '#Parameter \#1 \$idCategory of class Category constructor expects null, int given#'