Merge pull request #4 from PrestaShop/boom-1597-commit-name-validation

Introduced Commit name validator

.gitignore

@@ -11,7 +11,7 @@
 !/var/sessions
 /var/sessions/*
 !var/sessions/.gitkeep
-!var/SymfonyRequirements.php
 /vendor/
 /web/bundles/
-var/bootstrap.php.cache
+var/bootstrap.php.cache
+web/config.php

app/Resources/views/markdown/pr_commit_name_nok.md.twig

@@ -0,0 +1,35 @@
+<!-- PR_COMMIT_NAME_ERROR -->
+Hi!
+
+These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our [guidelines](http://doc.prestashop.com/display/PS16/How+to+write+a+commit+message):
+
+{% if commits|length > 1 %}
+<table>
+  <tr>
+    <th>Malformed commits</th>
+  </tr>
+  {% for commit in commits %}
+    <tr>
+        <td>{{ commit }}</td>
+    </tr>
+  {% endfor %}
+</table>
+{% else %}
+<p>`{{ commits[0] }}` is malformed or incomplete.</p>
+{% endif %}
+
+A valid commit name can be, for instance:
+
+```
+BO: Shows company in BO search if B2B is enabled
+```
+
+Would you mind to amend your commits' names?
+
+To do this, open a command line window and use `git commit --amend` for the commit's name. See [GitHub's help page](https://help.github.com/articles/changing-a-commit-message/) for more information.
+
+_Note: this **must** be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface!_ :)
+
+Thank you!
+
+(note: this is an automated message, but answering it will reach a real human )

app/Resources/views/markdown/pr_table_errors.md.twig

@@ -1,3 +1,4 @@
+<!-- PR_TABLE_DESCRIPTION_ERROR -->
 Hi!
 
 Your pull request description seems to be incomplete or malformed:

app/config/services.yml

@@ -20,7 +20,7 @@ services:
         class: Github\Api\Issue
         factory: ['@app.github.client', api]
         arguments: [issue]
-    
+
     app.github.comments_api:
         class: Github\Api\Issue\Comments
         factory: ['@app.github.issues_api', comments]
@@ -34,7 +34,7 @@ services:
         class: Github\Api\Repo
         factory: ['@app.github.client', api]
         arguments: [repository]
-        
+
     app.github.organizations_api:
         class: Github\Api\Organization
         factory: ['@app.github.client', api]
@@ -49,6 +49,15 @@ services:
         class: Github\Api\Issue\Labels
         factory: ['@app.github.issues_api', labels]
 
+    app.github.gitdata_api:
+        class: Github\Api\GitData
+        factory: ['@app.github.client', api]
+        arguments: [gitData]
+
+    app.github.commits_api:
+        class: Github\Api\GitData\Commits
+        factory: ['@app.github.gitdata_api', commits]
+
 # Application GitHub API
 
     app.github.cached_labels_api:
@@ -75,7 +84,11 @@ services:
 
     app.pullrequest_listener:
         class: AppBundle\PullRequests\Listener
-        arguments: ['@app.comment_api', '@validator', '@app.pull_request.repository']
+        arguments:
+            - '@app.comment_api'
+            - '@app.commit.repository'
+            - '@validator'
+            - '@app.pull_request.repository'
 
 # Event subscribers
 
@@ -127,6 +140,14 @@ services:
         class: AppBundle\Search\Repository
         arguments: ['@app.github.search_api', '%repository_username%', '%repository_name%']
 
+    app.commit.repository:
+        class: AppBundle\Commits\Repository
+        arguments:
+            - '@app.github.commits_api'
+            - '@app.github.pullrequests_api'
+            - '%repository_username%'
+            - '%repository_name%'
+
 # Reporters
 
     app.pull_requests.reporter:

app/config/services_test.yml

@@ -20,4 +20,8 @@ services:
     # Your integrations tests shouldn't post comments to github
     app.pullrequest_listener:
         class: Tests\AppBundle\PullRequests\FakeListener
-        arguments: ['@app.comment_api', '@validator', '@twig']
+        arguments:
+            - '@app.comment_api'
+            - '@validator'
+            - '@twig'
+            - '@app.commit.repository'

composer.json

@@ -26,7 +26,7 @@
         "sensio/distribution-bundle": "^5.0",
         "sensio/framework-extra-bundle": "^3.0.2",
         "incenteev/composer-parameter-handler": "^2.0",
-        "knplabs/github-api": "^1.4",
+        "knplabs/github-api": "^1.7",
         "lp-digital/github-event-parser": "~0.7"
     },
     "require-dev": {