Release version 4.3.1 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Nov 24, 2023
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Release a new version of this module. |
| Type? | |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? | No extra test needed, it was already tested - the only changes are removing some controllers from the list. |
Do not include blocked pages
Update README.md
Update README.md
Check if the hook is present before adding it
Replace old urls
Bump version to 4.3.1
Remove tab link
ShaiMagal
approved these changes
Nov 24, 2023
Remove function "GSITEMAP_CHECK_IMAGE_FILE" - too problematic
ShaiMagal
approved these changes
Nov 29, 2023
|
I can't test this, due to PrestaShop/PrestaShop#34728 |
boherm
approved these changes
Dec 5, 2023
|
@florine2623 @AureRita Ready to be tested ;) |
|
Bump @florine2623 for quick test🙏 |
|
Hi @Hlavtox, I tested the PR on older shop myself and everything works correctly. XML files generated on a live store is the same and the UI works correctly. :-)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.