Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change include init.php place #104

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Change include init.php place #104

merged 1 commit into from
Apr 14, 2020

Conversation

arthtux
Copy link
Contributor

@arthtux arthtux commented Jan 29, 2019 •
edited by PierreRambaud
Loading

Change init.php for don't include this if you use phpCLI.

the reason:

  • if you include but you run gsitemap-cron.php with phpCLI with PS_SSL_ENABLED at 1 the exit script.

How to test:

Run gsitemap-cron.php in CLI with SSL activated

@Progi1984 Progi1984 requested a review from a team November 28, 2019 16:12
@sarahdib sarahdib self-assigned this Apr 14, 2020
@Progi1984 Progi1984 merged commit de1680b into PrestaShop:dev Apr 14, 2020
@Progi1984
Copy link
Member

Thanks @arthtux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees

@sarahdib sarahdib

Labels
QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthtux @Progi1984 @PierreRambaud @sarahdib