Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Build Workflow for Github Actions #14

Merged

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Feb 19, 2021

Questions Answers
Description? Added Build Workflow for Github Actions
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A
Possible impacts? N/A

Can't check on my fork as Github Actions are not enabled in the repo

@Progi1984 Progi1984 requested a review from a team February 19, 2021 10:06
Copy link
Member

@eternoendless eternoendless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matks
Copy link
Contributor

matks commented Feb 19, 2021

@Progi1984 I fetch your branch and pushed it on my fork.

It fails for a very weird reason 😮

https://github.com/matks/decimal/runs/1935660154

# Install dependencies

0s
Run composer install --no-interaction
  composer install --no-interaction
  shell: /bin/bash -e {0}
Composer could not find a composer.json file in /home/runner/work/decimal/decimal
To initialize a project, please create a composer.json file as described in the https://getcomposer.org/ "Getting Started" section
Error: Process completed with exit code 1.

@PierreRambaud
Copy link
Contributor

@Progi1984 I fetch your branch and pushed it on my fork.

It fails for a very weird reason

https://github.com/matks/decimal/runs/1935660154

# Install dependencies

0s
Run composer install --no-interaction
  composer install --no-interaction
  shell: /bin/bash -e {0}
Composer could not find a composer.json file in /home/runner/work/decimal/decimal
To initialize a project, please create a composer.json file as described in the https://getcomposer.org/ "Getting Started" section
Error: Process completed with exit code 1.

Should be better with my change

@matks
Copy link
Contributor

matks commented Feb 23, 2021

@Progi1984 I fetch your branch and pushed it on my fork.
It fails for a very weird reason
https://github.com/matks/decimal/runs/1935660154

# Install dependencies

0s
Run composer install --no-interaction
  composer install --no-interaction
  shell: /bin/bash -e {0}
Composer could not find a composer.json file in /home/runner/work/decimal/decimal
To initialize a project, please create a composer.json file as described in the https://getcomposer.org/ "Getting Started" section
Error: Process completed with exit code 1.

Should be better with my change

There was no checkout ? Haha I missed that 🤣 shame on me

@Progi1984 Progi1984 merged commit 9d9cc52 into PrestaShop:develop Feb 23, 2021
@Progi1984
Copy link
Member Author

Thanks @PierreRambaud @eternoendless @matks

@Progi1984 Progi1984 deleted the migrateTravisCIToGithubActions branch February 23, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants