Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sass-loader from 14 to 13 to be compatible with Node16 #650

Conversation

leemyongpakva
Copy link
Contributor

@leemyongpakva leemyongpakva commented Feb 17, 2024

Questions Answers
Description? sass-loader 14.1.0 require at least Node 18.12.0, that most of packages in this repo are not compatible to. dependabot tried to bump sass-loader from v13 to v14 in #638 and #643
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #{issue URL here}, Fixes #{another issue URL here}
Sponsor company Your company or customer's name goes here (if applicable).
How to test? Apply the PR change, then try npm install & npm run build with Node 16

Screenshot from 2024-02-17 11-12-11

@ps-jarvis ps-jarvis added the waiting for QA Status: Waiting for QA feedback label Feb 19, 2024
@AureRita AureRita removed the waiting for QA Status: Waiting for QA feedback label Feb 26, 2024
@leemyongpakva
Copy link
Contributor Author

@AureRita What can we do next with this PR ?

@leemyongpakva
Copy link
Contributor Author

@matthieu-rolland We are in need of this PR merge for Release v6.0.0. AureRita removed Waiting QA so I guess you can make QA by dev.

@leemyongpakva leemyongpakva added this to the 6.0.0 milestone Mar 12, 2024
@AureRita
Copy link

Hi @leemyongpakva

Sorry for the long time you spend without my answer, currently this one can only be QAed by dev, I'll put a waiting for dev to give your PR more visibility

@leemyongpakva
Copy link
Contributor Author

OK. It looks like we have a plan to stop using Node 14 and Node 16 in this repo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants