Release 5.1.3 #565

kpodemski · 2023-06-08T06:39:16Z

Questions	Answers
Description?	New version
Type?	new feature
BC breaks?	no
Deprecations?	no
Fixed ticket?	n/a
How to test?	Exploratory tests of the module

resort devDependencies

fix overflow textlabel and inputbox in xs and sm screens

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.20.12 to 7.21.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.0/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [eslint](https://github.com/eslint/eslint) from 8.34.0 to 8.35.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.34.0...v8.35.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…slint-8.35.0 Bump eslint from 8.34.0 to 8.35.0

…abel/core-7.21.0 Bump @babel/core from 7.20.12 to 7.21.0

Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/webpack-contrib/style-loader/releases) - [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/style-loader@v3.3.1...v3.3.2) --- updated-dependencies: - dependency-name: style-loader dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…tyle-loader-3.3.2 Bump style-loader from 3.3.1 to 3.3.2

Bumps [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.19.1 to 7.21.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.3/eslint/babel-eslint-parser) --- updated-dependencies: - dependency-name: "@babel/eslint-parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…abel/eslint-parser-7.21.3 Bump @babel/eslint-parser from 7.19.1 to 7.21.3

Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.75.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.21.0 to 7.21.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.3/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…ck-5.76.0 Bump webpack from 5.75.0 to 5.76.0

…abel/core-7.21.3 Bump @babel/core from 7.21.0 to 7.21.3

Bumps [eslint](https://github.com/eslint/eslint) from 8.35.0 to 8.36.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.35.0...v8.36.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…slint-8.36.0 Bump eslint from 8.35.0 to 8.36.0

Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.75.0...v5.76.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ebpack-5.76.1 Bump webpack from 5.75.0 to 5.76.1

Please update actions to use Node.js 16

Bumps [webpack](https://github.com/webpack/webpack) from 5.76.1 to 5.76.2. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.76.1...v5.76.2) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…ebpack-5.76.2 Bump webpack from 5.76.1 to 5.76.2

Bumps [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin) from 2.7.2 to 2.7.5. - [Release notes](https://github.com/webpack-contrib/mini-css-extract-plugin/releases) - [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/mini-css-extract-plugin@v2.7.2...v2.7.5) --- updated-dependencies: - dependency-name: mini-css-extract-plugin dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…ini-css-extract-plugin-2.7.5 Bump mini-css-extract-plugin from 2.7.2 to 2.7.5

Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 13.2.0 to 13.2.1. - [Release notes](https://github.com/webpack-contrib/sass-loader/releases) - [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/sass-loader@v13.2.0...v13.2.1) --- updated-dependencies: - dependency-name: sass-loader dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…ass-loader-13.2.1 Bump sass-loader from 13.2.0 to 13.2.1

leemyongpakvn · 2023-09-04T13:42:57Z

@MhiriFaten I see you used gh pr checkout 565 in Checked with Chrome screencast, but don't know what you did prior. Please provide more information about how you made a fresh install before that command (eg: uninstall with files deleted options then install v5.1.2 in BO, or rm -rf then git clone in Terminal).

kpodemski · 2023-09-04T13:48:42Z

@leemyongpakvn I'm starting to think that it might be related to the shop being in the directory called x.y.z

leemyongpakvn · 2023-09-05T03:04:14Z

@kpodemski Maybe, we need a QA member who can test this PR in a simpler directory.
Beside that, I doubt gh pr checkout 565 is not the correct way to test this PR:

When I tried unsintall the module with ✅ Optional: delete module folder after uninstall, reinstall v5.1.2 in BO, then cd modules/blockreassurance & gh pr checkout 565 in Terminal, it breaks the whole site.
All files changed of this PR were already merged to dev branch, so git clone https://github.com/PrestaShop/blockreassurance.git is the best way to make a fresh install.

@florine2623 I wonder if QA team has a standard procedure to test a Release PR like this one ❓

kpodemski · 2023-09-05T06:20:04Z

@leemyongpakvn there is a process to test such releases, and gh pr checkout 565 should definitely not break your site, maybe you forgot to run composer install --no-dev?

We have to test it in the subdirectory. I tested it using multistore and virtual URI and it worked fine, but I didn't test it in the subdirectory.

leemyongpakvn · 2023-09-05T08:25:38Z

@kpodemski Maybe I ran gh pr checkout 565 in modules directory and it broke the whole site in the previous test :(
Case 1. If you install the module via Back-Office, it does not contain git file, so gh pr checkout 565 will returns error

could not determine base repo: fatal: not a git repository (or any of the parent directories): .git
/usr/bin/git: exit status 128

Case 2. If you do a fresh install with git clone https://github.com/PrestaShop/blockreassurance.git then 'gh pr checkout 565' will returns something like this

Already on 'dev'
Your branch is up to date with 'origin/dev'.
Already up to date.

Back to MhiriFaten's Checked with Chrome screencast. In fact, she ran git branch between 0:01 to 0:02 and got dev *pr-565. I got just * dev when running git branch on my side. So I still want to know how QA make a fresh install of a Release PR 🙏

MhiriFaten · 2023-09-05T08:59:45Z

@leemyongpakvn I meant that it can't be a cache issue as long as I clear the cache and the PR was added on a fresh installed shop.

leemyongpakvn · 2023-09-05T09:52:54Z

@MhiriFaten OK. Then you can try Krystian's suggestion: using a simpler directory :)

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.11 to 7.22.17. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.17/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…abel/core-7.22.17 Bump @babel/core from 7.22.11 to 7.22.17

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.17 to 7.22.20. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [eslint](https://github.com/eslint/eslint) from 8.48.0 to 8.50.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.48.0...v8.50.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…slint-8.50.0 Bump eslint from 8.48.0 to 8.50.0

…abel/core-7.22.20 Bump @babel/core from 7.22.17 to 7.22.20

Bumps [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.22.11 to 7.22.15. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.15/eslint/babel-eslint-parser) --- updated-dependencies: - dependency-name: "@babel/eslint-parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…abel/eslint-parser-7.22.15 Bump @babel/eslint-parser from 7.22.11 to 7.22.15

…slint-plugin-import-2.28.1 Bump eslint-plugin-import from 2.27.5 to 2.28.1

matks · 2023-09-27T12:26:06Z

I just tried to install blockreassurance v5.1.3 inside a subfolder named 1.2.3 and it works very well for me, I cannot reproduce the issues encountered by QA team. I will suggest a pair testing.

florine2623

Hello all,

On my end, I can reproduce any of the issues mentioned by @MhiriFaten and @aniszr 😅

Here are the screenrecords:

About this comment
#565 (review)

PS 8.0.5 ✅

Screen.Recording.2023-09-29.at.09.53.50.mov

PS 1.7.8.10 ✅

Screen.Recording.2023-09-29.at.10.21.04.mov

About this comment
#565 (review)

PS 8.1.2 ✅

Screen.Recording.2023-09-29.at.10.27.03.mov

So it is QA ✅
Thanks all ^^

matks · 2023-09-29T08:31:19Z

Thank you @florine2623 !

I strongly suggest we do merge this PR only on Monday, I would feel safer 😊

leemyongpakvn · 2023-10-02T05:43:38Z

Thanks @florine2623, @kpodemski and @matks

leemyongpakvn and others added 30 commits February 4, 2023 17:09

stop using simonwep/pickr

473937e

resort devDependencies

stop using simonwep/pickr

aa9a535

remove simonwep/pickr format

97b4c6b

use HTML input color instead of simonwep/pickr

eadfcc0

fix overflow textlabel and inputbox in xs and sm screens

rebuild assets

b36ca5f

Merge pull request #500 from PrestaShop/dependabot/npm_and_yarn/dev/e…

8a30220

…slint-8.35.0 Bump eslint from 8.34.0 to 8.35.0

Merge pull request #499 from PrestaShop/dependabot/npm_and_yarn/dev/b…

91a69c6

…abel/core-7.21.0 Bump @babel/core from 7.20.12 to 7.21.0

Please update actions to use Node.js 16

246206d

Merge pull request #508 from PrestaShop/dependabot/npm_and_yarn/dev/s…

3722628

…tyle-loader-3.3.2 Bump style-loader from 3.3.1 to 3.3.2

Merge pull request #509 from PrestaShop/dependabot/npm_and_yarn/dev/b…

2b9ff8d

…abel/eslint-parser-7.21.3 Bump @babel/eslint-parser from 7.19.1 to 7.21.3

Merge pull request #511 from PrestaShop/dependabot/npm_and_yarn/webpa…

cb6c7ed

…ck-5.76.0 Bump webpack from 5.75.0 to 5.76.0

Merge pull request #510 from PrestaShop/dependabot/npm_and_yarn/dev/b…

b6fb1e3

…abel/core-7.21.3 Bump @babel/core from 7.21.0 to 7.21.3

Merge pull request #507 from PrestaShop/dependabot/npm_and_yarn/dev/e…

132f16b

…slint-8.36.0 Bump eslint from 8.35.0 to 8.36.0

Merge pull request #506 from PrestaShop/dependabot/npm_and_yarn/dev/w…

2219ead

…ebpack-5.76.1 Bump webpack from 5.75.0 to 5.76.1

Merge pull request #504 from leemyongpakvn/patch-1

dbce4ed

Please update actions to use Node.js 16

Merge pull request #512 from PrestaShop/dependabot/npm_and_yarn/dev/w…

94eeeb7

…ebpack-5.76.2 Bump webpack from 5.76.1 to 5.76.2

Merge pull request #513 from PrestaShop/dependabot/npm_and_yarn/dev/m…

b2c8319

…ini-css-extract-plugin-2.7.5 Bump mini-css-extract-plugin from 2.7.2 to 2.7.5

Merge pull request #515 from PrestaShop/dependabot/npm_and_yarn/dev/s…

e56df83

…ass-loader-13.2.1 Bump sass-loader from 13.2.0 to 13.2.1

update following current dev branch

40fbbe4

MhiriFaten added the waiting for author Status: Waiting for Author Feedback label Sep 4, 2023

dependabot bot and others added 2 commits September 11, 2023 04:02

Merge pull request #598 from PrestaShop/dependabot/npm_and_yarn/dev/b…

ab5c7cf

…abel/core-7.22.17 Bump @babel/core from 7.22.11 to 7.22.17

leemyongpakvn mentioned this pull request Sep 13, 2023

Fix removing previous module files in PHPStan tests PrestaShop/pagesnotfound#36

Merged

dependabot bot and others added 8 commits September 18, 2023 04:11

Merge pull request #601 from PrestaShop/dependabot/npm_and_yarn/dev/e…

d11e391

…slint-8.50.0 Bump eslint from 8.48.0 to 8.50.0

Merge pull request #600 from PrestaShop/dependabot/npm_and_yarn/dev/b…

42aa6ba

…abel/core-7.22.20 Bump @babel/core from 7.22.17 to 7.22.20

Merge pull request #596 from PrestaShop/dependabot/npm_and_yarn/dev/b…

a92bc59

…abel/eslint-parser-7.22.15 Bump @babel/eslint-parser from 7.22.11 to 7.22.15

Merge pull request #589 from PrestaShop/dependabot/npm_and_yarn/dev/e…

18fff03

…slint-plugin-import-2.28.1 Bump eslint-plugin-import from 2.27.5 to 2.28.1

Merge pull request #594 from kpodemski/improved-phpstan-script

ee3434c

boherm approved these changes Sep 26, 2023

View reviewed changes

florine2623 approved these changes Sep 29, 2023

View reviewed changes

florine2623 self-assigned this Sep 29, 2023

florine2623 added QA ✔️ Status: QA-Approved and removed waiting for author Status: Waiting for Author Feedback labels Sep 29, 2023

This was referenced Oct 1, 2023

Update link to contribution guidelines #603

Merged

Remove PULL_REQUEST_TEMPLATE.md #604

Merged

leemyongpakvn merged commit e2d375e into master Oct 2, 2023
30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 5.1.3 #565

Release 5.1.3 #565

kpodemski commented Jun 8, 2023

leemyongpakvn commented Sep 4, 2023 •

edited

Loading

kpodemski commented Sep 4, 2023

leemyongpakvn commented Sep 5, 2023 •

edited

Loading

kpodemski commented Sep 5, 2023

leemyongpakvn commented Sep 5, 2023

MhiriFaten commented Sep 5, 2023

leemyongpakvn commented Sep 5, 2023

matks commented Sep 27, 2023

florine2623 left a comment

matks commented Sep 29, 2023

leemyongpakvn commented Oct 2, 2023

Release 5.1.3 #565

Release 5.1.3 #565

Conversation

kpodemski commented Jun 8, 2023

leemyongpakvn commented Sep 4, 2023 • edited Loading

kpodemski commented Sep 4, 2023

leemyongpakvn commented Sep 5, 2023 • edited Loading

kpodemski commented Sep 5, 2023

leemyongpakvn commented Sep 5, 2023

MhiriFaten commented Sep 5, 2023

leemyongpakvn commented Sep 5, 2023

matks commented Sep 27, 2023

florine2623 left a comment

Choose a reason for hiding this comment

matks commented Sep 29, 2023

leemyongpakvn commented Oct 2, 2023

leemyongpakvn commented Sep 4, 2023 •

edited

Loading

leemyongpakvn commented Sep 5, 2023 •

edited

Loading