Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined variable versionNumberRegex #906

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

fer-av
Copy link

@fer-av fer-av commented Sep 21, 2024

versionNumberRegex Not define!!!

Questions Answers
Description? No anda Expert mode -> Canal: directorio local
Type? bug fix
BC breaks? yes
Deprecations? yes
Fixed ticket?
Sponsor company eflyshop
How to test? hice el cambio y actualice mi sitio!

@ps-jarvis
Copy link
Collaborator

Hello @fer-av!

This is your first pull request on autoupgrade repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

js/upgrade.js Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@M0rgan01
Copy link
Contributor

M0rgan01 commented Sep 23, 2024

@fer-av Hello! Thanks for the contribution, and for restoring the missing variable!

However, the upgrade.js file will be completely refactored into typescript for the introduction of a new UI on the next major release.

On the other hand it is possible to target the 6.x branch, which may have minor or patch releases in the future.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from dev to 6.x September 25, 2024 14:56
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Sep 25, 2024

This variable is indeed not used anymore in the upgrade.js file on the dev branch (https://github.com/PrestaShop/autoupgrade/pull/902/files#diff-35ef954ff7799e931a3e99706a3bca463d56a3c77729d5755311b9ebcb93c1acL837), and the incoming version will provide a new UI.

I changed the base branch for 6.x but it requires a rebase on your end.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from 6.x to dev December 2, 2024 10:40
@Quetzacoalt91 Quetzacoalt91 changed the base branch from dev to 6.x December 2, 2024 10:41
fer-av and others added 2 commits December 2, 2024 10:41
versionNumberRegex Not define!!!
Co-authored-by: Sébastien Alfaiate <seb33300@hotmail.com>
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@AureRita AureRita self-assigned this Dec 9, 2024
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fer-av

Thank you for your PR, I tested it and it seems to works as you can see :

recording.13.webm

Tested from :
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@Quetzacoalt91 Quetzacoalt91 merged commit 23e3274 into PrestaShop:6.x Dec 9, 2024
34 of 35 checks passed
@Quetzacoalt91 Quetzacoalt91 changed the title Update upgrade.js Fix undefined variable versionNumberRegex Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants