-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined variable versionNumberRegex
#906
Conversation
Hello @fer-av! This is your first pull request on autoupgrade repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@fer-av Hello! Thanks for the contribution, and for restoring the missing variable! However, the upgrade.js file will be completely refactored into typescript for the introduction of a new UI on the next major release. On the other hand it is possible to target the 6.x branch, which may have minor or patch releases in the future. |
This variable is indeed not used anymore in the upgrade.js file on the I changed the base branch for 6.x but it requires a rebase on your end. |
versionNumberRegex Not define!!!
Co-authored-by: Sébastien Alfaiate <seb33300@hotmail.com>
293e023
to
23cca0f
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fer-av
Thank you for your PR, I tested it and it seems to works as you can see :
recording.13.webm
Tested from :
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
versionNumberRegex
versionNumberRegex Not define!!!