Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated PHPStan in project as composer dependency #702

Merged
merged 5 commits into from
May 28, 2024

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented May 20, 2024

Questions Answers
Description? The version of PHPStan is quite old (https://packagist.org/packages/phpstan/phpstan#0.12.100). This PR updates it, merge all the different workflow to an existing bash file then obviously fixes all the new errors reported by PHPStan.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Non regression tests should be run. Twig has been removed in this PR, so display of the configuration should be checked on different versions of PS (i.e 1.7.3, 1.7.6, 1.7.8, 8.0, 9.0)

@Quetzacoalt91 Quetzacoalt91 self-assigned this May 20, 2024
@Quetzacoalt91 Quetzacoalt91 force-pushed the phpstan-upgrade branch 7 times, most recently from c3edde9 to b227d63 Compare May 22, 2024 11:19
@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review May 22, 2024 11:20
M0rgan01
M0rgan01 previously approved these changes May 22, 2024
tests/composer.json Outdated Show resolved Hide resolved
@Quetzacoalt91 Quetzacoalt91 force-pushed the phpstan-upgrade branch 2 times, most recently from defa43a to c39fca9 Compare May 23, 2024 12:37
tests/unit/UpgradeContainerTest.php Show resolved Hide resolved
tests/phpstan/phpstan-1.7.8.neon Outdated Show resolved Hide resolved
@Quetzacoalt91 Quetzacoalt91 added this to the 6.0.0 milestone May 24, 2024
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91

I tested your module from 1.7.1.0 to 1.7.3.0 as you can see :

recording.219.webm

and i have this error :
image

But this one is not related to your PR.

Except that, That what I have :

recording.220.webm

I tested it from :
1.7.3.0 to 1.7.6.0
1.7.6.0 to 1.7.8.9
1.7.8.9 to 8.0.5
8.0.0 to 9.0.0

on all of them I do a rollback except for 8.0.0 to 9.0.0.
I tested the autoupgrade module on 9.0.0 on it works

Because the PR seems to works correctly, I think it's a QA ✔️

Thank you !

@nicosomb nicosomb merged commit 012623c into PrestaShop:dev May 28, 2024
29 checks passed
@Quetzacoalt91 Quetzacoalt91 deleted the phpstan-upgrade branch December 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants