-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updated PHPStan in project as composer dependency #702
Conversation
Quetzacoalt91
commented
May 20, 2024
•
edited
Loading
edited
Questions | Answers |
---|---|
Description? | The version of PHPStan is quite old (https://packagist.org/packages/phpstan/phpstan#0.12.100). This PR updates it, merge all the different workflow to an existing bash file then obviously fixes all the new errors reported by PHPStan. |
Type? | improvement |
BC breaks? | Nope |
Deprecations? | Nope |
Fixed ticket? | / |
Sponsor company | @PrestaShopCorp |
How to test? | Non regression tests should be run. Twig has been removed in this PR, so display of the configuration should be checked on different versions of PS (i.e 1.7.3, 1.7.6, 1.7.8, 8.0, 9.0) |
c3edde9
to
b227d63
Compare
defa43a
to
c39fca9
Compare
c39fca9
to
7f44281
Compare
7f44281
to
91d4bcb
Compare
91d4bcb
to
b3f9c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested your module from 1.7.1.0 to 1.7.3.0 as you can see :
recording.219.webm
But this one is not related to your PR.
Except that, That what I have :
recording.220.webm
I tested it from :
1.7.3.0 to 1.7.6.0
1.7.6.0 to 1.7.8.9
1.7.8.9 to 8.0.5
8.0.0 to 9.0.0
on all of them I do a rollback except for 8.0.0 to 9.0.0.
I tested the autoupgrade module on 9.0.0 on it works
Because the PR seems to works correctly, I think it's a QA ✔️
Thank you !