-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 8.1.6.sql to 8.1.7.sql #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matks Can I merge it or I would get banned?
CI is red |
@matks True, and we should also ask QA before |
@matks Can you please rebase? |
@Quetzacoalt91 Done ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matks
Thank you for your PR, I tested it and it seems to works as you can see :
recording.211.webm
Tested from 8.1.5 to 8.1.6 only (because I already check it on other PR)
Because the PR seems to works as expected, It's QA ✔️
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AureRita Can you please verify the QA process again?
On your video, you still have 8.1.5 after the upgrade.
Also, you just showed us that your database has changed, but it SHOULD NOT change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Hlavtox
Indeed It was a strange version 8.1.6 that I have ( when I load it to a new shop, it write 8.1.5 ... )
But, I do the test again and as you can see :
recording.213.webm
With a do an upgrade from a minor version to go on 8.1.6, I don't have the changes ✔️
When I specified that's a 8.1.7, I have the changes ✔️
So it's QA ✔️
Description
PrestaShop 8.1.6 was a security release, so we did not bundle all the PRs merged for 8.1.6 in it. Instead, we simply created 8.1.6 by fetching the 8.1.5 tag and then adding the content of the security patch on top of it.
The PRs merged for 8.1.6 on branch 8.1.x have been milestoned 8.1.7 instead and will be delivered with patch release 8.1.7 . Consequently it is necessary to rename file 8.1.6.sql to 8.1.7.sql