-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align ignoring rules between copy and deletion of files + ignore native module only if they have they vendor/ folder #699
Align ignoring rules between copy and deletion of files + ignore native module only if they have they vendor/ folder #699
Conversation
…ched (= their autoloader is still the one present in the core)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good for me nice refacto and improvement but I have just a question about /vendor file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, I tested it and it seems to works.
Tested on :
1.7.8.11 to 8.1.6
8.0.5 to 8.1.6 ( you corrected this PR : PrestaShop/PrestaShop#36184 )
8.0.5 to 9.0.0 ( you corrected this PR : PrestaShop/PrestaShop#36153 )
8.1.5 to 8.1.16
8.1.5 to 9.0.0
8.1.6 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
This also changes the way native modules are ignored. If one of them has never been modified (meaning their composer is still the one provided by the core), its content will be upgraded during the process.
ps_googleanalytics
module during "Upgrade files" step.* Installation of 8.1.0, deletion and reinstallation of module
ps_googleanalytics
, then upgrade to PS 8.1.6 should not delete or copy the module contents during "Upgrade files" step.Error currently found in the CI and fixed by this PR:
This is related to a module
ps_googleanalytics
provided in both packages 8.1.0 and 8.1.6. In PrestaShop releases, native module dependencies are merged in the core composer.This can be confirmed by checking if a vendor/ folder is present in the module contents:
When installing PrestaShop 8.1.0 and upgrade immediately to 8.1.6, the new core dependencies are copied but:
These 2 issues are respectively fixed by each topic covered in the description.