Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphan tabs following deletion of old controllers #698

Merged
merged 1 commit into from
May 14, 2024

Conversation

Quetzacoalt91
Copy link
Member

Questions Answers
Description? While upgrading to PrestaShop v9, remove tabs who lost their parent relation with the previous row deletion. this cleans the table and fixes an issue reported while opening the Stock page.
Type? bug fix
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes PrestaShop/PrestaShop#35879
Sponsor company PrestaShopCorp
How to test? Upgrade from PS 8 to 9, then open the Stock page. It should load without error.

@AureRita
Copy link
Contributor

Hi @Quetzacoalt91

Thank you for your PR, I tested it on :

8.1.5 to 9.0.0, that works without any exception

but when I try to upgrade from 8.0.5 to 9.0.0, that what I have :

recording.202.webm

Waiting for your correction

@Quetzacoalt91
Copy link
Member Author

Seen with @AureRita: Because the stack trace relates to a module it is interesting to see if the error can be reproduced on the dev branch as well.

Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again,

After a little review, I see that the issue is not due to your PR, so it's QA ✔️

@nicosomb nicosomb merged commit 84b595e into PrestaShop:dev May 14, 2024
29 checks passed
@nicosomb nicosomb added this to the 5.0.2 milestone May 14, 2024
@Quetzacoalt91 Quetzacoalt91 deleted the remove-orphan-tabs branch May 14, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Autoupgrade - When you do an upgrade to 9.0.0, you can't go on stock page
5 participants