Add a check about PS_VERSION_DB #696
Conversation
Quetzacoalt91
force-pushed
the
add-check-about-PS_VERSION_DB
branch
from
6e7f870 to
3972539
Compare
classes/UpgradeSelfCheck.php
Outdated
| return version_compare( | ||
| Configuration::get('PS_VERSION_DB'), | ||
| $this->prestashopConfiguration->getPrestaShopVersion(), | ||
| '>=' |
There was a problem hiding this comment.
Because if for any reason the version stored in db is above the current PrestaShop, the message displayed asking to run migration files does not make sense. I want to get the message only if the version is below, and "<" is the opposite of ">=".
There was a problem hiding this comment.
I changed in favor of == following @AureRita checks
There was a problem hiding this comment.
Thank you for your PR, I tested it and it show me correctly the error when I have a previous version on PS_Version_DB and not when I have a newest version as you can see :
recording.203.webm
I tested it on
8.0.5, 8.1.6, 1.7.8.10
I try to do an upgrade from 8.0.5 to 8.1.6 with the major release, all seems ok
but when I try to do an upgrade from 1.7.8.10 to 8.1.6 with the major release, I have this error
And when I want to go on the BO :
recording.204.webm
FYI : When I do the upgrade, I put the version 8.1.0 in de PS_Version_DB
Waiting for correction
Quetzacoalt91
force-pushed
the
add-check-about-PS_VERSION_DB
branch
from
481e61a to
5365ad7
Compare
Quetzacoalt91
force-pushed
the
add-check-about-PS_VERSION_DB
branch
from
5365ad7 to
10e30e3
Compare
There was a problem hiding this comment.
Thank you for your PR, I tested it and it seems to works as you can see :
recording.217.webm
Tested on :
1.7.8.11 (major Upgrade to 8.1.6)
8.0.5 (major Upgrade to 8.1.6)
8.1.5 (Minor Upgrade to 8.1.6)
8.1.6
Because the PR seems to works as expected, It's QA ✔️
Thank you
This PR also removes some duplicated code to get the module version.