Fix tab visibility on PrestaShop 9

[ga-devfront]

Questions	Answers
Description?	Fix tab visibility on PrestaShop 9
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#35726
Sponsor company	@PrestaShopCorp
How to test?	You can try to install the module on V8 or V9 all run as expected.

[kpodemski]

blocking for investigation tomorrow

[ga-devfront]

blocking for investigation tomorrow

About what ?

[kpodemski]

Hello @ga-devfront

The new tab system was introduced years ago, not in PrestaShop 9. This is why I blocked the PR yesterday: I find the title, commit name, and comment in the code confusing.

Could you point me to the PR from PrestaShop 9 introducing "DEFAULT" tab? Otherwise, let's rephrase everything that mentioned v9 as a reason why it didn't work 👍🏻

[Quetzacoalt91]

I see what you mean @kpodemski. I think DEFAULT is the reference to the parent tab introduced in PrestaShop 1.7 when the sidebar has been reworked (PrestaShop/PrestaShop@fef7eba?diff=split&w=1).

Since this rework, using AdminTools as parent triggered a fallback on Default. The method responsible of this will be removed in PrestaShop v9, explaining why the Upgrade module was not visible anymore: PrestaShop/PrestaShop@178c4a4

This breaking change can be documented as other very old modules may encounter the say issue.

[AureRita]

Hi @ga-devfront

Thank you for your PR, I tested it and it seems to works as you can see :

Tested on 8.0.5, 8.1.5 and develop

Because the PR seems to works as expected, It's QA ✔️

Thank you

[kpodemski]

thank you @ga-devfront