Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the ean13 field #680

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Update the ean13 field #680

merged 1 commit into from
Apr 10, 2024

Conversation

tleon
Copy link
Contributor

@tleon tleon commented Mar 26, 2024 •
edited by Hlavtox
Loading

Questions Answers
Description? Update the ean13 field to a varchar(20) for PR PrestaShop/PrestaShop#35697.
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company PrestaShop SA
How to test? CI 🟢

@tleon tleon self-assigned this Mar 26, 2024
@tleon tleon force-pushed the Issue-25974-allow-ean-14 branch from 80a62df to d0416bd Compare March 26, 2024 14:11
@Hlavtox Hlavtox added the Blocked Status: The issue is blocked by another task label Mar 27, 2024
@Hlavtox Hlavtox mentioned this pull request Mar 27, 2024
Merged
@Hlavtox
Copy link
Contributor

Hlavtox commented Mar 27, 2024

To be tested after PrestaShop/PrestaShop#35697 is merged.

@paulnoelcholot paulnoelcholot removed the Blocked Status: The issue is blocked by another task label Apr 9, 2024
@AureRita AureRita self-assigned this Apr 9, 2024
AureRita
AureRita reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tleon

Thank you for your PR, I tested it and it seems to works as you can see :

image

image

image

Tested on :
8.0.5 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 8.1.5 to 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@nicosomb nicosomb added this to the 5.0.2 milestone Apr 10, 2024
@nicosomb nicosomb merged commit d4b2385 into PrestaShop:dev Apr 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureRita AureRita AureRita left review comments

@boherm boherm boherm approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees

@tleon tleon

@AureRita AureRita

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
8 participants
@tleon @Hlavtox @jolelievre @boherm @AureRita @nicosomb @ps-jarvis @paulnoelcholot