Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add category redirect columns #678

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add category redirect columns #678

merged 1 commit into from
Apr 4, 2024

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Mar 19, 2024 •
edited
Loading

Questions Answers
Description? Add category redirect columns
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#35500
Sponsor company -
How to test? after an upgrade to v9, ensure the addition of new column redirect_type and id_type_redirected in the PREFIX_category table. Also check that the root category is in redirect_type 404

@M0rgan01 M0rgan01 added this to the 5.0.2 milestone Mar 19, 2024
@M0rgan01 M0rgan01 mentioned this pull request Mar 19, 2024
Merged
jolelievre
jolelievre previously approved these changes Mar 19, 2024
View reviewed changes
@M0rgan01 M0rgan01 force-pushed the category_redirect branch from b7807c4 to 65867f9 Compare March 19, 2024 17:40
boherm
boherm previously approved these changes Mar 20, 2024
View reviewed changes
@florine2623
Copy link

@M0rgan01 could you specify the How to test ?
Upgrade from which version to which version and what should be checked exactly ?

Do we need to wait until PrestaShop/PrestaShop#35608 is fixed to test it ?

@Hlavtox Hlavtox added the Blocked Status: The issue is blocked by another task label Mar 20, 2024
@Hlavtox
Copy link
Contributor

Hlavtox commented Mar 20, 2024

@florine2623 To be tested after the related PR is merged. 👍

tleon
tleon previously approved these changes Mar 25, 2024
View reviewed changes
@M0rgan01 M0rgan01 added waiting for QA and removed waiting for author Blocked Status: The issue is blocked by another task labels Mar 26, 2024
@M0rgan01 M0rgan01 dismissed stale reviews from tleon and boherm via b5d8e24 March 28, 2024 12:49
@M0rgan01 M0rgan01 force-pushed the category_redirect branch from 65867f9 to b5d8e24 Compare March 28, 2024 12:49
AureRita
AureRita approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M0rgan01

Thank you for your PR, I tested it and it seems to works as you can see :

image

Tested on :
8.0.5 -> 9.0.0
8.0.5 -> 8.1.5 -> 9.0.0
8.1.5 -> 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@nicosomb nicosomb merged commit 151a511 into PrestaShop:dev Apr 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureRita AureRita AureRita approved these changes

@boherm boherm boherm approved these changes

@jolelievre jolelievre jolelievre approved these changes

@tleon tleon tleon approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.

Add a redirection function 301 or 302 on Category page
9 participants
@M0rgan01 @florine2623 @Hlavtox @tleon @jolelievre @boherm @AureRita @nicosomb @ps-jarvis