Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actionValidateCartRule hook #672

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add actionValidateCartRule hook #672

merged 1 commit into from
Apr 18, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 25, 2024

Questions Answers
Description? Adds new hook introduced in PrestaShop/PrestaShop#34875.
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test? Run query manually.

@Hlavtox Hlavtox added this to the 5.0.1 milestone Feb 25, 2024
@Hlavtox Hlavtox mentioned this pull request Feb 25, 2024
Merged
@Hlavtox Hlavtox modified the milestones: 5.0.1, 5.0.2 Feb 27, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Apr 3, 2024

To be merged after PrestaShop/PrestaShop#34875

@Hlavtox Hlavtox added the Blocked Status: The issue is blocked by another task label Apr 3, 2024
@Hlavtox Hlavtox removed the Blocked Status: The issue is blocked by another task label Apr 17, 2024
@Hlavtox Hlavtox requested review from tleon and a team April 17, 2024 10:27
@AureRita AureRita self-assigned this Apr 18, 2024
AureRita
AureRita approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hlavtox

Thank you for your PR, I tested it and it seems to works as you can see :

recording.192.webm

Tested on :
8.0.5 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 8.1.5 to 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@boherm boherm merged commit 9b6218f into PrestaShop:dev Apr 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureRita AureRita AureRita approved these changes

@ga-devfront ga-devfront ga-devfront approved these changes

@boherm boherm boherm approved these changes

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

@tleon tleon Awaiting requested review from tleon

Assignees

@AureRita AureRita

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Hlavtox @Quetzacoalt91 @boherm @ga-devfront @AureRita @ps-jarvis