Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(configuration): added default configuration value for category b… #670

Merged
merged 1 commit into from
May 10, 2024
Merged

feat(configuration): added default configuration value for category b… #670

merged 1 commit into from
May 10, 2024

Conversation

Dreimus
Copy link
Contributor

@Dreimus Dreimus commented Feb 16, 2024 •
edited by Hlavtox
Loading

If the product is accessed from another category than product default category, it will generate the breadcrumb according to current category.

Questions Answers
Branch? develop
Description? By default, product breadcrumb is generated by using product default category. With this feature, if a category is stored on the product controller and assigned to the viewed product, the breadcrumb will be generated accordingly.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
Related PRs PrestaShop/PrestaShop#30546
How to test? Upgrade to 9.0.0 branch or run the query manually.

@Dreimus
Copy link
Contributor Author

Dreimus commented Feb 16, 2024

Ping @kpodemski

@Hlavtox Hlavtox added this to the 5.0.1 milestone Feb 16, 2024
@Hlavtox Hlavtox added the Blocked Status: The issue is blocked by another task label Feb 16, 2024
@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 16, 2024

We can merge after PrestaShop/PrestaShop#30546 is merged. 👍

@Hlavtox Hlavtox modified the milestones: 5.0.1, 5.0.2 Feb 27, 2024
@ga-devfront ga-devfront added waiting for QA and removed Blocked Status: The issue is blocked by another task labels Apr 29, 2024
@ga-devfront
Copy link
Contributor

PR PrestaShop/PrestaShop#30546 is merged. Need to be tested by QA before merging it.

@kpodemski
Copy link
Contributor

@PrestaShop/qa-functional considering it only sets the default value in the database, I don't think this PR requires any manual tests

@Robin-Fischer-PS
Copy link
Contributor

Hi @kpodemski ,

Indeed it does not require any manual tests, I let you or any other maintainer check it and merge it :)

And thanks for the PR @Dreimus !

@nicosomb nicosomb merged commit 16f65e3 into PrestaShop:dev May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ga-devfront ga-devfront ga-devfront approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

Assignees
No one assigned
Labels
QA ✔️ waiting for dev
Projects
PR Dashboard
Archived in project
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Dreimus @Hlavtox @ga-devfront @kpodemski @Robin-Fischer-PS @nicosomb