Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index to PREFIX_orders.invoice_date #560

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Conversation

AdrienPlx
Copy link
Contributor

Related to pull request PrestaShop/PrestaShop#31218. Improve back office performances on Categories lisiting

Questions Answers
Description? Add index to PREFIX_orders.invoice_date to increase performances on AdminStatsController ajax function to get best category on KPIs listing of categories in BO (huge timing on big shops)
Type? improvement
How to test? Go to categories listing page in BO and analyse network timing on this request : index.php?controller=AdminStats&ajax=1&action=getKpi&kpi=top_category. It will be significant if you have a shop with a lot of categories, orders and products. Add the index on ps_orders.'invoice_date' and see the difference

Related to pull request PrestaShop/PrestaShop#31218. Improve back office performances on Categories lisiting
@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 6, 2023

@AdrienPlx Bro can you add the two SESSION and NAMES commands to the top like here? https://github.com/AdrienPlx/autoupgrade/blob/patch-1/upgrade/sql/8.1.0.sql

Not sure if its needed, but just to be safe. 👍

@kpodemski kpodemski added the Blocked Status: The issue is blocked by another task label Feb 17, 2023
@AdrienPlx
Copy link
Contributor Author

@AdrienPlx Bro can you add the two SESSION and NAMES commands to the top like here? https://github.com/AdrienPlx/autoupgrade/blob/patch-1/upgrade/sql/8.1.0.sql

Not sure if its needed, but just to be safe. 👍

Hi, this is done !

Hlavtox
Hlavtox previously approved these changes Feb 20, 2023
@kpodemski kpodemski added waiting for author and removed Blocked Status: The issue is blocked by another task labels Apr 19, 2023
@kpodemski
Copy link
Contributor

hey @AdrienPlx

Your PR to the core has been merged 🎉 do you think you could resolve conflicts in this PR? There were some others in the meantime.

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 24, 2023

Bump @AdrienPlx

@AdrienPlx
Copy link
Contributor Author

I think it's ok ! @Hlavtox

@Hlavtox Hlavtox merged commit 3dd77c6 into PrestaShop:dev Dec 28, 2023
23 checks passed
@Hlavtox Hlavtox added this to the 5.0.1 milestone Dec 28, 2023
@Hlavtox
Copy link
Contributor

Hlavtox commented Dec 28, 2023

Tested, works properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants