Run E2E tests on master #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boubkerbribri
commented
Sep 10, 2021
boubkerbribri
commented
| Questions | Answers |
|---|---|
| Description? | Since E2E tests run only on the dev branch, we don't have real-time errors on upgrades. So adding run on the main branch |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | no |
| How to test? | no tests needed |
| Possible impacts? | none |
added 7 commits
September 10, 2021 11:50
boubkerbribri
commented
Sep 10, 2021
Comment on lines
+65
to
+75
| - run: | | ||
| cp -r .github .github_dev | ||
| cp -r tests/e2e tests/e2e_dev | ||
| cp docker-compose.yml docker-compose.dev.yml | ||
| git fetch origin ${{ matrix.module_branch }} | ||
| git checkout ${{ matrix.module_branch }} | ||
| rm -rf .github docker-compose.yml tests/e2e | ||
| mv .github_dev .github | ||
| mv tests/e2e_dev tests/e2e | ||
| mv docker-compose.dev.yml docker-compose.yml | ||
| if: ${{ matrix.module_branch != 'dev' }} |
There was a problem hiding this comment.
Since some directories/files are not merged on the master branch, adding the same files from the dev branch to be able to run tests.
boubkerbribri
commented
Sep 10, 2021
| @@ -38,7 +38,8 @@ Upgrade | |||
| Log out | |||
| Check new version | |||
| */ | |||
| describe(`Upgrade PrestaShop from '${global.PS_VERSION}' to '${global.PS_VERSION_UPGRADE_TO}'`, async () => { | |||
| // eslint-disable-next-line max-len | |||
| describe(`[${global.AUTOUPGRADE_VERSION}] Upgrade PrestaShop from '${global.PS_VERSION}' to '${global.PS_VERSION_UPGRADE_TO}'`, async () => { | |||
There was a problem hiding this comment.
This is a hack to make tests look like the capture since the nightly site can't handle how to insert and display 2 module's branches.
atomiix
approved these changes
Sep 10, 2021
PierreRambaud
approved these changes
Sep 13, 2021
|
Thank you @boubkerbribri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.