Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nightly upgrades using User Interface #387

Merged
merged 35 commits into from
Mar 17, 2021

Conversation

boubkerbribri
Copy link
Contributor

Questions Answers
Description? Add cron to test upgrade from "1.7.4.4", "1.7.5.2", "1.7.6.9", "1.7.7.1" to today builds on nightly (1.7.7.2 and 1.7.8.0) with user interface
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? https://github.com/boubkerbribri/autoupgrade/actions/runs/642660002
Possible impacts? none

@boubkerbribri boubkerbribri requested a review from atomiix March 11, 2021 12:21
Copy link
Contributor

@atomiix atomiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment but seems good overall 👍

tests/e2e/scenarios/02_upgrade.js Show resolved Hide resolved
atomiix
atomiix previously approved these changes Mar 15, 2021
working-directory: ./tests/e2e

outputs:
target_versions: ${{ steps.set-target-versions.outputs.TARGET_VERSIONS }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the modification ef3122b but I got a context error Unrecognized named-value: 'env'. So I deleted it.

Copy link
Contributor

@PierreRambaud PierreRambaud Mar 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it should be only one job, they are linked, one can't work without the other.

Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using Dockerfile inside .github directory, I don't get it?
And few comments, I really think GitHub actions have to be easy to read, you should prefer bash scripts instead of multiple yaml tasks.

@boubkerbribri
Copy link
Contributor Author

Why using Dockerfile inside .github directory, I don't get it?
And few comments, I really think GitHub actions have to be easy to read, you should prefer bash scripts instead of multiple yaml tasks.

I used the one who already was there to not create a new one, maybe we can ask @atomiix about this.

@atomiix
Copy link
Contributor

atomiix commented Mar 15, 2021

I've put the Dockerfile in the .github folder because it is not intended to be used for something else that the Github actions, but if you think we should put it somewhere else, I'm ok with that :)

atomiix
atomiix previously approved these changes Mar 16, 2021
@boubkerbribri boubkerbribri changed the title Add Nightly upgrades using User Infterface [WIP] Add Nightly upgrades using User Infterface Mar 16, 2021
@boubkerbribri boubkerbribri changed the title [WIP] Add Nightly upgrades using User Infterface Add Nightly upgrades using User Infterface Mar 16, 2021
@boubkerbribri
Copy link
Contributor Author

Looks good now runs/2121453573

atomiix
atomiix previously approved these changes Mar 16, 2021
atomiix
atomiix previously approved these changes Mar 17, 2021
@jolelievre jolelievre merged commit 5f70c16 into PrestaShop:dev Mar 17, 2021
@boubkerbribri boubkerbribri deleted the add-e2e-tests branch March 17, 2021 15:47
@matks
Copy link
Contributor

matks commented Mar 22, 2021

THIS IS AMAZING

@matks matks changed the title Add Nightly upgrades using User Infterface Add Nightly upgrades using User Interface Mar 22, 2021
@PierreRambaud PierreRambaud added this to the 4.13.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants