-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nightly upgrades using User Interface #387
Conversation
boubkerbribri
commented
Mar 11, 2021
Questions | Answers |
---|---|
Description? | Add cron to test upgrade from "1.7.4.4", "1.7.5.2", "1.7.6.9", "1.7.7.1" to today builds on nightly (1.7.7.2 and 1.7.8.0) with user interface |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | no |
How to test? | https://github.com/boubkerbribri/autoupgrade/actions/runs/642660002 |
Possible impacts? | none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment but seems good overall 👍
working-directory: ./tests/e2e | ||
|
||
outputs: | ||
target_versions: ${{ steps.set-target-versions.outputs.TARGET_VERSIONS }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the modification ef3122b but I got a context error Unrecognized named-value: 'env'.
So I deleted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it should be only one job, they are linked, one can't work without the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using Dockerfile inside .github directory, I don't get it?
And few comments, I really think GitHub actions have to be easy to read, you should prefer bash scripts instead of multiple yaml tasks.
I used the one who already was there to not create a new one, maybe we can ask @atomiix about this. |
I've put the Dockerfile in the .github folder because it is not intended to be used for something else that the Github actions, but if you think we should put it somewhere else, I'm ok with that :) |
#Ignore warning
e48bdc4
to
d56a3e3
Compare
Looks good now runs/2121453573 |
THIS IS AMAZING |