Add more nightly tests and re-enable 1.6 migration test #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atomiix
commented
Mar 4, 2021
atomiix
commented
| Questions | Answers |
|---|---|
| Description? | This PR aims to add nightly migration tests by adding 1.6.1.24 & 1.7.7.0 to the list of versions to migrate from. It also re-enable migration from 1.6.1.11 in the "classic" tests. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? | CI should be green |
| Possible impacts? |
| $rii = new RecursiveIteratorIterator(new RecursiveDirectoryIterator('./artifacts')); | ||
| $files = []; | ||
| foreach ($rii as $file) { | ||
| if ($file->isDir() || strpos($file->getPathname(), $branch . '.txt') === false) { |
There was a problem hiding this comment.
Suggested change
| if ($file->isDir() || strpos($file->getPathname(), $branch . '.txt') === false) { | |
| if ($file->isDir() || strpos($file->getPathname(), $branch . '.txt') === false) { |
IF you're looking for a file name ended by $branch . '.txt' it's maybe easier to use a regex to resolve the issue
There was a problem hiding this comment.
I think it’s simpler like that because branch name can contain characters that must be escaped if using regex, not needed when using strpos
There was a problem hiding this comment.
Don't forget https://www.php.net/manual/fr/function.preg-quote.php :D
Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>
PierreRambaud
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.