Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid drop of some tables like guests #369

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Avoid drop of some tables like guests #369

merged 1 commit into from
Jul 19, 2021

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Dec 1, 2020 •
edited
Loading

Questions Answers
Description? Fix deletion of some tables by mistake
Type? bug fix
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Backup, upgrade then restore, the customer data must remain in DB

@matks
Copy link
Contributor

matks commented Dec 1, 2020

2 GitHub Actions fail but I think it's weird items. There is a PHP5.6 GA build successfull. The other must be bad duplicates.

@Quetzacoalt91
Copy link
Member Author

Quetzacoalt91 commented Dec 2, 2020 •
edited
Loading

This seems to be related to GitHub itself.
image

Can you restart the workflow just in case?

@Progi1984
Copy link
Member

@Quetzacoalt91 I restarted them this morning : same result.

@atomiix
Copy link
Contributor

atomiix commented Dec 2, 2020

@Quetzacoalt91 isn't there something to do here too? https://github.com/PrestaShop/autoupgrade/blob/master/classes/TaskRunner/Upgrade/BackupDb.php#L110

@Quetzacoalt91
Copy link
Member Author

@Quetzacoalt91 isn't there something to do here too? https://github.com/PrestaShop/autoupgrade/blob/master/classes/TaskRunner/Upgrade/BackupDb.php#L110

The table is not part of the backup. We mustn't drop it when we restore the database as it won't be recovered. What do you expect at this place @atomiix ? That we finally add the guests table to the list of data to save?

@atomiix
Copy link
Contributor

atomiix commented Apr 1, 2021

@Quetzacoalt91 I don't remember why I said that 😅
But I don't think it is useful add the guest table to the list of data to save.

@Progi1984 Progi1984 merged commit 68c82ce into PrestaShop:dev Jul 19, 2021
@Progi1984
Copy link
Member

Thanks @Quetzacoalt91 & @sarahdib

@Quetzacoalt91 Quetzacoalt91 deleted the avoid-drop-of-tables branch May 8, 2024 16:02
@Quetzacoalt91 Quetzacoalt91 mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Quetzacoalt91 @matks @Progi1984 @atomiix @PierreRambaud @sarahdib