Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test upgrades for PS1.7 with php7.1 #361

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Test upgrades for PS1.7 with php7.1 #361

merged 1 commit into from
Nov 27, 2020

Conversation

matks
Copy link
Contributor

@matks matks commented Nov 26, 2020

Questions Answers
Description? Test upgrades for PS1.7 with php7.1
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Travis test should pass

@matks matks mentioned this pull request Nov 26, 2020
Open
@matks
Copy link
Contributor Author

matks commented Nov 27, 2020

Thank you for review!

@matks matks merged commit 4cc5920 into PrestaShop:dev Nov 27, 2020
@matks matks deleted the test-with-php71 branch November 27, 2020 20:36
@matks
Copy link
Contributor Author

matks commented Nov 27, 2020

Just realized this test is probably useless. Because

  • phpunit tests will be moved in GitHub Actions
  • phpstan tests and integration tests are run in a docker image so the PHP version used by Travis does not matter

@matks matks mentioned this pull request Nov 27, 2020
Merged
@Progi1984 Progi1984 added this to the 4.11.0 milestone Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matks @atomiix @Progi1984