Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PHPUnit Tests to GA #360

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Move PHPUnit Tests to GA #360

merged 2 commits into from
Nov 26, 2020

Conversation

matks
Copy link
Contributor

@matks matks commented Nov 26, 2020 •
edited
Loading

Questions Answers
Description? Move PHPUnit Tests to GitHub Action. Also test on php5.6 and php7.2!
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? GA should pass

@matks
Copy link
Contributor Author

matks commented Nov 26, 2020

The GA pass on my fork matks#3

atomiix
atomiix reviewed Nov 26, 2020
View reviewed changes
.github/workflows/php.yml Outdated Show resolved Hide resolved
@matks matks force-pushed the move-phpunit-to-ga branch from 44a0abf to deebaf9 Compare November 26, 2020 13:21
@matks
Copy link
Contributor Author

matks commented Nov 26, 2020

Thanks for review!

@matks matks merged commit b609300 into PrestaShop:dev Nov 26, 2020
@matks matks mentioned this pull request Nov 26, 2020
Open
@matks matks deleted the move-phpunit-to-ga branch November 30, 2020 20:44
@Progi1984 Progi1984 added this to the 4.11.0 milestone Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matks @atomiix @Progi1984