Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v4.9.0 upgrade filename #345

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

matks
Copy link
Contributor

@matks matks commented Jan 6, 2020

Questions Answers
Branch? develop
Description? v4.9.0 upgrade filename was wrong, so it was probably ignored 🤔
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Please check that, following an upgrade from a version < 4.9.0 to a version > 4.9.0 autoupgrade module is correctly registered on hook dashboardZoneOne and set to top

Quetzacoalt91
Quetzacoalt91 previously approved these changes Jan 6, 2020
@sarahdib
Copy link

sarahdib commented Apr 9, 2020

@matks
Could you rebase this pr please?
Thanks :)

@matks matks force-pushed the fix-upgrade-file-name branch from 0189aec to 09f391e Compare April 9, 2020 08:43
@matks
Copy link
Contributor Author

matks commented Apr 9, 2020

@sarahdib Rebased

@Progi1984
Copy link
Member

@matks Your PR can't be merged because Travis is in 🔴

@matks
Copy link
Contributor Author

matks commented Apr 10, 2020

@matks Your PR can't be merged because Travis is in 🔴

But QA said yes 😁

I checked the error:

$ composer install
install.2
$ docker-compose up -d
$ bash -c 'while [[ "$(curl -s -o /dev/null -w %{http_code} http://localhost:8001/index.php)" != "200" ]]; do sleep 5; done'
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

Faulty build => I restart

@Progi1984
Copy link
Member

I have ever restarted

@matks
Copy link
Contributor Author

matks commented Apr 10, 2020

... what a good way to start the day 😭 ...

@matks
Copy link
Contributor Author

matks commented Apr 20, 2020

Restarting Travis

@Progi1984
Copy link
Member

@matks Always 🔴 :(

@matks
Copy link
Contributor Author

matks commented Apr 21, 2020

Maybe if I retry again ? 😁

@Progi1984
Copy link
Member

I just tried.

@Progi1984
Copy link
Member

An idea @Quetzacoalt91 ?

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Apr 21, 2020

Yes, I found out the 1.6 tag of the docker image prestashop/prestashop does not start properly, there is an issue with a missing PHP library while installing PrestaShop.

PHP Fatal error:  Call to undefined function imagecreatefromjpeg() in /var/www/html/classes/ImageManager.php on line 486

@Quetzacoalt91
Copy link
Member

Related to PrestaShop/docker#211

@Progi1984
Copy link
Member

Thanks @Quetzacoalt91 ;)

@Progi1984 Progi1984 merged commit 8620a73 into PrestaShop:dev Apr 22, 2020
@Progi1984
Copy link
Member

Thanks @matks & @Quetzacoalt91 (for fixing Docker)

@matks matks deleted the fix-upgrade-file-name branch November 30, 2020 20:44
@Progi1984 Progi1984 added this to the 4.11.0 milestone Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants