[FIX] Fixed unintentional language update #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Dec 5, 2024
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | See PrestaShop/PrestaShop#33321 for context. After debugging, the problem comes from the installation of the Ps_distributionApiClient module. Each module installation updates the languages and associated tables, which causes our problem. Furthermore in the context of the autoupgrade module, no need to upgrade the languages because this is already done in another step |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#33321 |
| Sponsor company | - |
| How to test? | See PrestaShop/PrestaShop#33321 |
M0rgan01
force-pushed
the
fix-update-language
branch
from
734d5d4 to
da4bcc6
Compare
|
Quetzacoalt91
approved these changes
Dec 5, 2024
ga-devfront
approved these changes
Dec 5, 2024
AureRita
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as you can see : *
recording.11.webm
Tested from :
1.7.5.1 to 8.2
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.