-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .rank() method for multiple models #615
Conversation
@tqtg Could you please elaborate more? Based on my understanding, these models compute ranking scores by weighting the tradeoff between predicted ratings and top-k aspects via the following formula: We can replace |
I was thinking whether we can reuse the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The new
Recommender.rank()
function addsk
as required value, which breaks some models that do not usek
in ranking evaluation (e.g., ComparER, EFM, LRPPM).I putk
into**kwargs
and usek = kwargs.get("k", -1)
instead.Another option is to addk=None
to incompatible models.I added and updated topK ranking for mentioned models.