Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the main models table and example/tutorials in README #610

Merged

Conversation

lgabs
Copy link
Contributor

@lgabs lgabs commented Mar 29, 2024

  • Fixes [ASK] Is there a way to find all GPU supported models?  #609 (specifying CPU/GPU supported for each of the models).
  • Adding more links to existing examples and tutorials for the models. I think this table is where most users refer to when looking for model details. Therefore, having these links will raise visibility.

@tqtg
Copy link
Member

tqtg commented Mar 29, 2024

Hey @lgabs, thanks a lot for making this changes. It will be very helpful for model references. I'm just trying to merge environment and requirement into one column to save some space when displaying the whole table in the main page.

@lgabs
Copy link
Contributor Author

lgabs commented Mar 29, 2024

Thanks! Yeah, it will be better to save some space. I can do it too, if you didn't start this change yet.

@tqtg
Copy link
Member

tqtg commented Mar 29, 2024

Let me try to propose some changes first and see if you're good with that.

@lgabs
Copy link
Contributor Author

lgabs commented Mar 29, 2024

Nice, i'm good with that change, it's cleaner now.

@tqtg
Copy link
Member

tqtg commented Mar 29, 2024

@lgabs sorry for introducing other changes to this PR. However, I think it's a good chance to have more example/tutorial links added to the main table for users reference.

@tqtg
Copy link
Member

tqtg commented Mar 29, 2024

tagging other key contributors to seek for better ideas @darrylong @lthoang @hieuddo @saghiles

@tqtg tqtg changed the title [docs] add gpu supported info in models list Improve the main models table Mar 29, 2024
@tqtg tqtg added the docs Documentation (Readme, readthedocs) related label Mar 29, 2024
@lgabs lgabs changed the title Improve the main models table Improve the main models table and example/tutorials in README Mar 29, 2024
@darrylong
Copy link
Member

I agree to these changes, it's okay so long as it is readable to users.

Anyway, non-related but i'm exploring an idea to add this table to our readthedocs documentation site with a filter/sort function. This will be explored in another PR.

@tqtg tqtg merged commit 335d4a6 into PreferredAI:master Mar 31, 2024
13 of 14 checks passed
@lgabs lgabs deleted the luan/describe-gpu-supported-models-readme branch June 17, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation (Readme, readthedocs) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ASK] Is there a way to find all GPU supported models?
3 participants