Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to evaluate every next item in next-item evaluation #580

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Jan 8, 2024

Description

Related Issues

#578

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@lthoang lthoang force-pushed the next-item-mode branch 2 times, most recently from dad914e to 7dc8f43 Compare January 9, 2024 09:39
cornac/eval_methods/base_method.py Outdated Show resolved Hide resolved
cornac/eval_methods/next_item_evaluation.py Outdated Show resolved Hide resolved
cornac/eval_methods/next_item_evaluation.py Outdated Show resolved Hide resolved
cornac/eval_methods/base_method.py Outdated Show resolved Hide resolved
@lthoang lthoang force-pushed the next-item-mode branch 3 times, most recently from e1d2d4c to ff85aaa Compare January 10, 2024 09:37
@lthoang lthoang requested a review from tqtg January 10, 2024 09:40
@tqtg
Copy link
Member

tqtg commented Jan 10, 2024

LGTM. Feel free to merge

@lthoang lthoang merged commit aed8ece into PreferredAI:master Jan 12, 2024
13 of 14 checks passed
@lthoang lthoang deleted the next-item-mode branch January 12, 2024 07:38
@darrylong darrylong added the feature New feature/enhancement request label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature/enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants