Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Session Popular model #575

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Fix Session Popular model #575

merged 2 commits into from
Dec 30, 2023

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Dec 30, 2023

Description

The ranking score is based on item frequency should be zeros by default. The current scoring function may be wrong when item id does not in the counter.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@lthoang lthoang requested review from tqtg and hieuddo December 30, 2023 03:23
Copy link
Member

@hieuddo hieuddo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lthoang lthoang merged commit b69a235 into PreferredAI:master Dec 30, 2023
13 checks passed
@lthoang lthoang deleted the spop-fix branch December 30, 2023 07:00
@darrylong darrylong added the models New models, changes to models label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models New models, changes to models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants