Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Session-based Recommendations With Recurrent Neural Networks (GRU4Rec) model #574

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Dec 28, 2023

Description

This is an adaptation of an official implementation of GRU4Rec.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@lthoang lthoang requested review from hieuddo and tqtg December 29, 2023 14:35
@tqtg tqtg added feature New feature/enhancement request models New models, changes to models labels Dec 29, 2023
cornac/models/gru4rec/gru4rec.py Show resolved Hide resolved
cornac/models/gru4rec/recom_gru4rec.py Outdated Show resolved Hide resolved
cornac/models/spop/recom_spop.py Outdated Show resolved Hide resolved
@tqtg
Copy link
Member

tqtg commented Dec 29, 2023

@lthoang please also consider adding model into the docs

@lthoang lthoang requested a review from tqtg December 30, 2023 03:58
@tqtg
Copy link
Member

tqtg commented Jan 2, 2024

LGTM

@tqtg
Copy link
Member

tqtg commented Jan 3, 2024

@lthoang @hieuddo just curious whether we obtain comparable results to the original implementation on the same dataset?

@lthoang
Copy link
Member Author

lthoang commented Jan 4, 2024

@lthoang @hieuddo just curious whether we obtain comparable results to the original implementation on the same dataset?

To be able to compare with original implementation, we need to further add an evaluation option for evaluating every next item in test sequence.
I have mentioned in #543 (comment)

@tqtg Should we also include that in this PR, or create a separate PR?

@tqtg
Copy link
Member

tqtg commented Jan 4, 2024

@lthoang let have this merged and we can work on another PR for that evaluation feature

@lthoang lthoang merged commit 031f32b into PreferredAI:master Jan 5, 2024
13 checks passed
@lthoang lthoang deleted the gru4rec branch January 5, 2024 01:27
@darrylong darrylong removed the feature New feature/enhancement request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models New models, changes to models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants