Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back Circle CI for publishing code coverage #573

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

tqtg
Copy link
Member

@tqtg tqtg commented Dec 27, 2023

Description

Previously, we had Circle CI workflow to publish code coverage to codecov.io which shows the badge in our README. It stopped working at some point, we then removed it together with updating GitHub actions. Let's try to add it back for tracking test coverage. Alternatively, this could be added as part of the GitHub actions.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@tqtg tqtg requested a review from darrylong December 27, 2023 18:15
@darrylong
Copy link
Member

@tqtg Was thinking if we should utilize Github Actions instead so we don't have to maintain both CircleCI and Github Actions.
Or is there a feature we would like to use in CircleCI that Actions doesn't have?

@tqtg
Copy link
Member Author

tqtg commented Dec 29, 2023

not really about any particular feature that we want from CircleCI, just that we can use a separate CI tailored for checking additional information (e.g., code coverage, code lint). GitHub actions can be designated for building and checking compatibility across different Python versions.

@tqtg tqtg added the feature New feature/enhancement request label Dec 29, 2023
@darrylong
Copy link
Member

@tqtg That sounds fine to me. While I noticed that there's an updated circleci python orb, shall we first get the current version working first before bumping the version up in another PR?

@darrylong darrylong added maintenance Changes relating to build process, tools and libraries such as docs generation. and removed feature New feature/enhancement request labels Jan 5, 2024
@tqtg tqtg merged commit f2d44ce into PreferredAI:master Jan 5, 2024
13 checks passed
@tqtg tqtg deleted the circle-ci branch January 5, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes relating to build process, tools and libraries such as docs generation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants